Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{bio}[foss/2018b] bmtagger v3.101, SRPRISM v3.0.0 #7890

Merged
merged 2 commits into from
Mar 14, 2019
Merged

{bio}[foss/2018b] bmtagger v3.101, SRPRISM v3.0.0 #7890

merged 2 commits into from
Mar 14, 2019

Conversation

boegel
Copy link
Member

@boegel boegel commented Mar 14, 2019

(created using eb --new-pr)

@boegel
adding easyconfigs: bmtagger-3.101-foss-2018b.eb, SRPRISM-3.0.0-foss-…
dc1f8de 
…2018b.eb and patches: bmtagger-3.101_fix-hardcoding.patch, SRPRISM-3.0.0_fix-GCC-7.patch
@boegel boegel added the new label Mar 14, 2019
@boegel boegel added this to the 3.x milestone Mar 14, 2019
@boegel
Copy link
Member Author

boegel commented Mar 14, 2019

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node3108.skitty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/1310dfc86bc6e0c3889ad0ec391d8bfd for a full test report.

@boegel
Copy link
Member Author

boegel commented Mar 14, 2019

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2461.golett.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/863a2a0bf7b79b4dfe743c35943831d4 for a full test report.

@boegel
Copy link
Member Author

boegel commented Mar 14, 2019

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2012.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/c38cf609b1105a9c96b0a2f48c4f3706 for a full test report.

@boegel boegel mentioned this pull request Mar 14, 2019
Merged
wpoely86
wpoely86 reviewed Mar 14, 2019
View reviewed changes
easybuild/easyconfigs/b/bmtagger/bmtagger-3.101_fix-hardcoding.patch
@@ -0,0 +1,11 @@
fix hardcoding of compiler command & flags, by passing down $CXX, $CXX and $CXXFLAGS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're passing down CFLAGS, not CXXFLAGS?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wpoely86 The code is partially C & C++, and the flags are identical anyway...

@vanzod
Copy link
Member

vanzod commented Mar 14, 2019

Test report by @vanzod
FAILED
Build succeeded for 1 out of 3 (2 easyconfigs in this PR)
cermis - Linux debian 9.8, Intel(R) Xeon(R) CPU X5670 @ 2.93GHz, Python 2.7.13
See https://gist.github.com/80bda5104c86dbe70aa229452dac7a04 for a full test report.

@boegel
Copy link
Member Author

boegel commented Mar 14, 2019

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node3108.skitty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/f0fd1911142168b91efb06ae28bac79c for a full test report.

@vanzod
Copy link
Member

vanzod commented Mar 14, 2019

Test report by @vanzod
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
cermis - Linux debian 9.8, Intel(R) Xeon(R) CPU X5670 @ 2.93GHz, Python 2.7.13
See https://gist.github.com/108d30756b792278e8613a5105b2da2b for a full test report.

@vanzod vanzod modified the milestones: 3.x, next release (3.8.2) Mar 14, 2019
@vanzod
Copy link
Member

vanzod commented Mar 14, 2019

Going in, thanks @boegel!

@vanzod vanzod merged commit 0f22c36 into easybuilders:develop Mar 14, 2019
@boegel boegel deleted the 20190314191827_new_pr_bmtagger3101 branch March 17, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpoely86 wpoely86 wpoely86 left review comments

@vanzod vanzod vanzod approved these changes

Assignees
No one assigned
Labels
new
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@boegel @vanzod @wpoely86